QDox
  1. QDox
  2. QDOX-168

Parsing JavadocComment (please validate)

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8, 1.9, 1.9.1
    • Fix Version/s: 1.10
    • Component/s: Parser
    • Labels:
      None
    • Testcase included:
      yes
    • Number of attachments :
      2

      Description

      Untill now the javadoc comments were read by token/word. This works for most cases, but when comments are becomming complex because of the usage of asterikses (together with tabs and spaces) the result be slightly different then the input.
      I've rewritten the lexer, where the reading is based on lines instead of tokens. This makes the result much more solid, but requires some special lexing.
      One testcase had 2 javadoccomments in 1 line (no sourceformatting, just one line of code). To read untill the first javadocEnd I had to use regepx inside the lexer-tokenblock.

      When this patch is validated we can probably solve several open issues which refer to the usage of javadocs.

      1. javadoc-relexed.patch
        15 kB
        Robert Scholte
      2. qdox-168-fix.patch
        29 kB
        Robert Scholte

        Issue Links

          Activity

          Robert Scholte made changes -
          Field Original Value New Value
          Link This issue is depended upon by QDOX-154 [ QDOX-154 ]
          Robert Scholte made changes -
          Attachment qdox-168-fix.patch [ 43668 ]
          Hide
          Paul Hammant added a comment -

          Robert's Patch applied, some whitespace tests fixed to accommodate small changes.

          Show
          Paul Hammant added a comment - Robert's Patch applied, some whitespace tests fixed to accommodate small changes.
          Paul Hammant made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          Assignee Robert Scholte [ rfscholte ]

            People

            • Assignee:
              Robert Scholte
              Reporter:
              Robert Scholte
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: