Details
Description
Re.
http://qdox.codehaus.org/apidocs/com/thoughtworks/qdox/model/JavaClass.html#getInnerClasses()
The method getInnerClasses() seems to actually be listing all nested classes, including static nested classes, not just inner classes. This is a common misuse of the term "inner class". For definitions see
http://java.sun.com/docs/books/jls/second_edition/html/classes.doc.html
and search for "nested" and "inner", specifically
"An inner class is a nested class that is not explicitly or implicitly declared static."
You might consider renaming the method to JavaClass.getNestedClasses() for this reason, unless you are really returning only inner classes.
Activity
Mike Williams
made changes -
Field | Original Value | New Value |
---|---|---|
Fix Version/s | 1.6 [ 10814 ] |
Mike Williams
made changes -
Assignee | Mike Williams [ mdub ] |
Mike Williams
made changes -
Resolution | Fixed [ 1 ] | |
Status | Open [ 1 ] | Resolved [ 5 ] |
Good point, thanks. We should rename it (and retain getInnerClasses as a deprecated synonym).